-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for Flex target and update to the latest NBGL use cases #17
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #17 +/- ##
===========================================
+ Coverage 42.24% 49.14% +6.90%
===========================================
Files 5 8 +3
Lines 419 470 +51
Branches 0 120 +120
===========================================
+ Hits 177 231 +54
+ Misses 242 239 -3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Text is fine either way. But if there wasn't a good reason to change it for the flex I would prefer leaving the text the same.
Standardize on the following NBGL use cases:
nbgl_useCaseHomeAndSettings
nbgl_useCaseAddressReview
nbgl_useCaseReview
nbgl_useCaseReviewBlindSigning
Checklist
develop