Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Flex target and update to the latest NBGL use cases #17

Merged
merged 9 commits into from
Oct 30, 2024

Conversation

jasonxh
Copy link

@jasonxh jasonxh commented Sep 24, 2024

Standardize on the following NBGL use cases:

  • nbgl_useCaseHomeAndSettings
  • nbgl_useCaseAddressReview
  • nbgl_useCaseReview
  • nbgl_useCaseReviewBlindSigning

Checklist

  • App update process has been followed
  • Target branch is develop
  • Application version has been bumped

@codecov-commenter
Copy link

codecov-commenter commented Oct 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 49.14%. Comparing base (93aea10) to head (9d89e25).

Additional details and impacted files
@@             Coverage Diff             @@
##           develop      #17      +/-   ##
===========================================
+ Coverage    42.24%   49.14%   +6.90%     
===========================================
  Files            5        8       +3     
  Lines          419      470      +51     
  Branches         0      120     +120     
===========================================
+ Hits           177      231      +54     
+ Misses         242      239       -3     
Flag Coverage Δ
unittests 49.14% <ø> (+6.90%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

@kent-white kent-white left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Text is fine either way. But if there wasn't a good reason to change it for the flex I would prefer leaving the text the same.

src/ui/nbgl_display.c Show resolved Hide resolved
@lpascal-ledger lpascal-ledger merged commit 3b5ed13 into LedgerHQ:develop Oct 30, 2024
45 checks passed
@jasonxh jasonxh deleted the hao/flex-ledger branch October 30, 2024 17:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants